Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47211: Remove function re.template() and flag re.TEMPLATE #32300

Merged
merged 1 commit into from Apr 6, 2022
Merged

bpo-47211: Remove function re.template() and flag re.TEMPLATE #32300

merged 1 commit into from Apr 6, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 4, 2022 •
edited by bedevere-bot

They were undocumented and never working.

https://bugs.python.org/issue47211

@serhiy-storchaka
bpo-47211: Remove function re.template() and flag re.TEMPLATE
7a17c27 
They were undocumented and never working.
@vstinner
Copy link
Member

vstinner commented Apr 5, 2022

I search for re.template() and re.TEMPLATE with the regex (?i)re.template and no project of top 5000 PyPI projects use it. So I'm fine with removing it with no deprecation period.

$ ./search_pypi_top.py PYPI-2022-01-26-TOP-5000/ '(?i)re.template' -o re_template

vstinner
vstinner approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit b09184b into python:main Apr 6, 2022
@serhiy-storchaka serhiy-storchaka deleted the remove-re-template branch April 6, 2022 16:53
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 12, 2022
Closed
hroncok added a commit to hroncok/cpython that referenced this pull request May 24, 2022
@hroncok
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (…
2e8f218 
…pythonGH-32300)"

This reverts commit b09184b.

Fixes python#92728
serhiy-storchaka pushed a commit that referenced this pull request May 25, 2022
@hroncok
gh-92728: Restore re.template, but deprecate it (GH-93161)
16a7e4a 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
@miss-islington miss-islington mentioned this pull request May 25, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@hroncok @miss-islington
pythongh-92728: Restore re.template, but deprecate it (pythonGH-93161)
f191b17 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (pythonGH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @hroncok
gh-92728: Restore re.template, but deprecate it (GH-93161)
74b205b 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @vstinner @the-knights-who-say-ni @bedevere-bot