Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the code example for cookie signing. #3562

Merged
merged 1 commit into from Sep 14, 2017
Merged

Fixed the code example for cookie signing. #3562

merged 1 commit into from Sep 14, 2017

Conversation

sww
Copy link
Contributor

@sww sww commented Sep 14, 2017

The symmetrical cookie signing code example had a few issues:

  1. The blake2b function does not take the data keyword argument,
  2. The hex digest returned by sign was a string, whereas compare_digest expects bytes-like objects.
  3. There was a typo in compare_digesty.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta added docs Documentation in the Doc dir skip issue skip news labels Sep 14, 2017
@Mariatta Mariatta merged commit 312ffea into python:master Sep 14, 2017
@miss-islington
Copy link
Contributor

Thanks @sww for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Good catch and thanks for fixing it. CLA is not needed for this straightforward documentation update.
Thanks @sww and congrats on your first contribution to CPython 🌮

@miss-islington
Copy link
Contributor

Thanks @sww for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2017
@sww @miss-islington
[3.6] Improve code examples in hashlib cookie signing (pythonGH-3562)
e39e3cd 
The `blake2b` function does not take the `data` keyword argument.
The hex digest returned by sign was a string, whereas compare_digest expects bytes-like objects.
Typo fix: compare_digesty -> compare_digest
(cherry picked from commit 312ffea)
@bedevere-bot
Copy link

GH-3566 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit that referenced this pull request Sep 14, 2017
@miss-islington @Mariatta
Improve code examples in hashlib cookie signing (GH-3562) (GH-3566)
c8b6506 
The `blake2b` function does not take the `data` keyword argument.
The hex digest returned by sign was a string, whereas compare_digest expects bytes-like objects.
Typo fix: compare_digesty -> compare_digest
(cherry picked from commit 312ffea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sww @the-knights-who-say-ni @miss-islington @Mariatta @bedevere-bot