Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29666: correct documentation for enum.html #358

Merged
merged 1 commit into from Feb 28, 2017

Conversation

kartikanand
Copy link
Contributor

Correct documentation for enum.html by adding the fourth missing type Flag and correcting the wrongly mentioned IntFlag

@vstinner vstinner merged commit 6265842 into python:master Feb 28, 2017
@vstinner vstinner added docs Documentation in the Doc dir needs backport to 3.6 labels Feb 28, 2017
@vstinner
Copy link
Member

Thanks!

@kartikanand : this change needs to be backported, can you try to cherry-pick the change to the 3.6 branch using "git cherry-pick -x "?
https://docs.python.org/3.6/library/enum.html

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 1, 2017
Mariatta added a commit that referenced this pull request Mar 1, 2017
@kartikanand kartikanand deleted the fix-issue-29666 branch March 1, 2017 07:20
@vstinner
Copy link
Member

vstinner commented Mar 2, 2017

IHMO it's worth it to backport the change to Python 3.6. @kartikanand can you please try to cherry-pick the change to Python 3.6 using "git cherry-pick -x " ?

@kartikanand
Copy link
Contributor Author

@Haypo It seems @Mariatta has already merged it in 3.6 - #367

@vstinner
Copy link
Member

vstinner commented Mar 2, 2017

@Haypo It seems @Mariatta has already merged it in 3.6 - #367

Oh right, @Mariatta just forgot to mention the bpo number in its PR and commit message. I updated the issue, thanks.

@vstinner
Copy link
Member

vstinner commented Mar 2, 2017

@berkerpeksag berkerpeksag removed the needs backport to 3.6 label an hour ago

Why did you remove the label? Are you using this label to check if the backport was done or not? I prefer to keep the label even if the change was already backported to 3.6.

@berkerpeksag
Copy link
Member

Are you using this label to check if the backport was done or not?

Yes, this has been used to track backport statuses for a while. I suggest opening an issue at python/core-workflow to discuss this :)

jaraco pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants