[2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) #3611
Conversation
…ythonGH-3201) (cherry picked from commit a5b4ea1)
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
| @@ -1301,6 +1301,13 @@ textiowrapper_write(textio *self, PyObject *args) | |||
| Py_DECREF(text); | |||
| if (b == NULL) | |||
| return NULL; | |||
| if (!PyBytes_Check(b)) { | |||
There was a problem hiding this comment.
Unicode should be accepted too. _PyBytes_Join() in 2.7 supports unicode objects.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @serhiy-storchaka. |
|
Ah, I noticed that @miss-islington created a backporting PR, then it was closed and somebody created a new backporting PR. I missed that it was @miss-islington again! |
|
Yes sorry I mistakenly closed the other backport PR so I made miss-islington create another one... :( |
|
@serhiy-storchaka: What should we do with this PR? Close it? The bot is not going to update its PR according to your review :-) |
|
I think it should be closed after creating a correct backport. Otherwise we risk to lose it. Re-adding the "needs backport to 2.7" label in #3201 will just trigger creating yet one incorrect backport. |
|
As @orenmn pointed on the tracker, the code is correct. Only the test need to be fixed. |
|
I'm closing this since the proper backport with tests passing has been done in #3951. |
|
Thanks @Mariatta. |
(cherry picked from commit a5b4ea1)
https://bugs.python.org/issue31271