Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31571: Removing redundant information (Docs) #3691

Merged
merged 2 commits into from Sep 25, 2017
Merged

Conversation

gpkc
Copy link
Contributor

@gpkc gpkc commented Sep 22, 2017

Removing some stuff that is said twice.

https://bugs.python.org/issue31571

This information is already stated right below, with more detail and a link to a PEP.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@gpkc
Copy link
Contributor Author

gpkc commented Sep 22, 2017

Forgot I had to sign this agreement... Just did it.

@gpkc gpkc changed the title Removing redundant information Removing redundant information (Docs) Sep 22, 2017
@serhiy-storchaka
Copy link
Member

Where it is said the first time?

A PR which is not trivial (fixing a typo or like) needs an issue on the Python bug tracker for discussion. Please open an issue and add the "bpo-XXXXX:" prefix to a title.

@gpkc gpkc changed the title Removing redundant information (Docs) bpo-31571: Removing redundant information (Docs) Sep 24, 2017
@gpkc
Copy link
Contributor Author

gpkc commented Sep 24, 2017

@serhiy-storchaka Okay, done. What would be a trivial PR then?

@serhiy-storchaka
Copy link
Member

https://github.com/python/cpython/pulls?page=2&q=is%3Apr+label%3A%22skip+issue%22+is%3Aclosed

As for this issue, duplications are located distant one from other, it is not obvious what copy should be kept or both. This PR could be trivial for the author of changes which know his intention.

@Mariatta Mariatta merged commit 4a2d00c into python:master Sep 25, 2017
@miss-islington
Copy link
Contributor

Thanks @gpkc for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-3754 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2017
…tion (pythonGH-3691)

- Remove the second mention about the `u` prefix
- Remove the second mention about numeric literals do not include a sign
(cherry picked from commit 4a2d00c)
@Mariatta
Copy link
Member

Thanks @gpkc and congrats on your first contribution to CPython 🌮

Mariatta pushed a commit that referenced this pull request Sep 25, 2017
…H-3691) (GH-3754)

- Remove the second mention about the `u` prefix
- Remove the second mention about numeric literals do not include a sign
(cherry picked from commit 4a2d00c)
@gpkc gpkc deleted the patch-1 branch September 27, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants