Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using ranlib (closes bpo-31625) #3815

Merged
merged 1 commit into from Sep 29, 2017
Merged

stop using ranlib (closes bpo-31625) #3815

merged 1 commit into from Sep 29, 2017

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Sep 29, 2017 •
edited by bedevere-bot

Instead, simply pass 's' to ar.

https://bugs.python.org/issue31625

@benjaminp benjaminp force-pushed the benjamin-ranlib branch 2 times, most recently from 7fbcd48 to ef55784 Compare September 29, 2017 06:33
tiran
tiran approved these changes Sep 29, 2017
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder which OS forced us to call ar multiple times. Python doesn't have that many object files...

pitrou
pitrou reviewed Sep 29, 2017
View reviewed changes
Misc/NEWS.d/next/Build/2017-09-28-23-21-20.bpo-31625.Bb2NXr.rst Outdated
@@ -0,0 +1 @@
Stop using on static libraries. Instead, we assume ar supports the 's' flag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A word is missing here.

@benjaminp
stop using ranlib (closes bpo-31625)
87f3a87 
Instead, simply pass 's' to ar.
@benjaminp benjaminp merged commit d15108a into master Sep 29, 2017
@benjaminp benjaminp deleted the benjamin-ranlib branch September 29, 2017 15:43
stratakis pushed a commit to stratakis/cpython that referenced this pull request Nov 8, 2018
@benjaminp @stratakis
stop using ranlib (closes bpo-31625) (python#3815)
f3e3541 
Instead, simply pass 's' to ar.
@stratakis stratakis mentioned this pull request Nov 8, 2018
Merged
vstinner pushed a commit that referenced this pull request Nov 29, 2018
@stratakis @vstinner
[3.6] bpo-31625: Stop using ranlib (GH-10417)
e1b2103 
* stop using ranlib (closes bpo-31625) (#3815)

Instead, simply pass 's' to ar.

* explicitly list objects for the ar command (#3824)

$^ is not portable.

closes bpo-31625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou left review comments

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@benjaminp @tiran @pitrou @Mariatta @the-knights-who-say-ni @bedevere-bot