Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-31158: Fix nondeterministic read in test_pty (GH-3808) #3852

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 2, 2017

  • bpo-31158: Fix nondeterministic read in test_pty

  • Reuse existing readline implementation from io.

Thx to @pitrou

  • Updated comment

Ideally, this commit is fixuped into the previous commit. Since there is
already a comment on github, I won't rebase.
(cherry picked from commit e6f62f6)

https://bugs.python.org/issue31158

* bpo-31158: Fix nondeterministic read in test_pty

* Reuse existing readline implementation from io.

Thx to @pitrou

* Updated comment

Ideally, this commit is fixuped into the previous commit. Since there is
already a comment on github, I won't rebase.
(cherry picked from commit e6f62f6)
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner vstinner merged commit 66fb5ef into python:3.6 Oct 2, 2017
@miss-islington
Copy link
Contributor Author

Thanks, @Haypo!

@miss-islington miss-islington deleted the backport-e6f62f6-3.6 branch October 2, 2017 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants