Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31810: Add smelly test to TravisCI #4054

Closed
wants to merge 2 commits into from
Closed

bpo-31810: Add smelly test to TravisCI #4054

wants to merge 2 commits into from

Conversation

CuriousLearner
Copy link
Member

@CuriousLearner CuriousLearner commented Oct 19, 2017 •
edited by bedevere-bot

Adds make smelly to Travis

https://bugs.python.org/issue31810

taleinat
taleinat requested changes Oct 19, 2017
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new script: section in .travis.yml seems to override the previous script: section, thus make smelly is being run instead of the test suite. It should probably just be added to the existing script: section.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

taleinat
taleinat requested changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make smelly is now successfully run after the usual tests.

However, I'm not sure it will register as a failure with Travis CI in case a leaked symbol is found. It seems to me that it will just print some output, but that is not enough.

Find how to make Travis CI recognize this as a failed test when there are leaked symbols, and test that it actually works.

vstinner
vstinner requested changes Oct 20, 2017
View reviewed changes
.travis.yml
@@ -91,6 +91,8 @@ script:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then ./python Tools/scripts/patchcheck.py --travis $TRAVIS_PULL_REQUEST; fi
# `-r -w` implicitly provided through `make buildbottest`.
- make buildbottest TESTOPTS="-j4 -uall,-cpu"
# Run `make smelly` to check if Python leaks any symbols
- make smelly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, "make smelly" exits with an exit code 0 which means "success" even if libpython leaks a symbol :-( The change isn't as simple as I expected, sorry.

I wrote PR #4057 which reimplements "make smelly" in Python to get a non-zero exit code if libpython leaks a symbol.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I was looking for a workaround for the same.

I'd pick something else now. Thanks :)

@vstinner vstinner mentioned this pull request Oct 20, 2017
Merged
@vstinner
Copy link
Member

I merged my PR #4057.

@vstinner vstinner closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

@taleinat taleinat taleinat requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CuriousLearner @bedevere-bot @vstinner @taleinat @the-knights-who-say-ni