-
-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-31903: Release the GIL when calling into SystemConfiguration #4178
Conversation
Make sure we release the GIL when calling `SCDynamicStoreCopyProxies` to avoid potential deadlocking if other Python threads also call into `NSUserDefaults`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good.
@ronaldoussoren any updates on whether this can be merged? |
Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…on (pythonGH-4178) (cherry picked from commit 4859ba0) Co-authored-by: Max Bélanger <aeromax@gmail.com>
GH-9215 is a backport of this pull request to the 3.6 branch. |
Sorry, @maxbelanger and @benjaminp, I could not cleanly backport this to |
…on (pythonGH-4178) (cherry picked from commit 4859ba0) Co-authored-by: Max Bélanger <aeromax@gmail.com>
GH-9216 is a backport of this pull request to the 3.7 branch. |
Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Per details in issue tracker, make sure we release the GIL when calling
SCDynamicStoreCopyProxies
to avoid potential deadlocking if other Python threads also call intoNSUserDefaults
.https://bugs.python.org/issue31903