Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue bpo-31968 #4313

Closed
wants to merge 3 commits into from
Closed

Fix issue bpo-31968 #4313

wants to merge 3 commits into from

Conversation

k1nkreet
Copy link

@k1nkreet k1nkreet commented Nov 7, 2017

!!! If this is a backport PR (PR made against branches other than master),
please ensure that the PR title is in the following format:

[X.Y] <title from the original PR> (GH-NNNN)

Where: [X.Y] is the branch name, e.g. [3.6].To the right of the Branch menu, click New pull request.

Use the base branch dropdown menu to select the branch you'd like to merge your changes into, then use the compare branch drop-down menu to choose the topic branch you made your changes in.

Type a title and description for your pull request.

Click Create pull request.

Tip: After you create a pull request, you can ask a specific person to review your proposed changes. For more information, see "Requesting a pull request review."
After your pull request has been reviewed, it can be merged into the repository.

Further reading

"Creating a pull request from a fork"
"Changing the base branch of a pull request"
"Adding issues and pull requests to a project board from the sidebar"
Contact a human
Article versions
GitHub.com
GitHub Enterprise 2.11
GitHub Enterprise 2.10
GitHub Enterprise 2.9
GitHub Enterprise 2.8

GH-NNNN refers to the PR number from master.

PLEASE: Remove this headline!!!

https://bugs.python.org/issue31968

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@k1nkreet k1nkreet changed the title Fix issue 31968 Fix issue bro-31968 Nov 7, 2017
@k1nkreet k1nkreet changed the title Fix issue bro-31968 Fix issue bpo-31968 Nov 7, 2017
@k1nkreet k1nkreet closed this Nov 7, 2017
@k1nkreet
Copy link
Author

k1nkreet commented Nov 7, 2017

guidelines is not satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants