Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29718: Fixed compile on cygwin. #447

Closed
wants to merge 2 commits into from
Closed

bpo-29718: Fixed compile on cygwin. #447

wants to merge 2 commits into from

Conversation

AraHaan
Copy link
Contributor

@AraHaan AraHaan commented Mar 4, 2017

Python 3.7 had an issue just like 3.6 with the TLS entries. As such the only way to compile on Cygwin was to replace TLS with TSS. This also fixes issues that was present in the standard library and setup.py in the repo for cygwin as well. TSS is the thing that actually gets python 3.7 to work on cygwin and in fact the only thing currently so TLS is not really used on it at all after this is merged. This will not affect building on MAC, windows, nor even linux at all it will only affect cygwin.

$ ./python.exe
Python 3.7.0a0 (default:4243df51fe43+, Mar  3 2017, 20:14:50)
[GCC 6.3.0] on cygwin
Type "help", "copyright", "credits" or "license" for more information.
>>> 

@mention-bot
Copy link

@AraHaan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warsaw, @Haypo, @freddrake, @Yhg1s and @mhammond to be potential reviewers.

@@ -1177,7 +1177,7 @@ get_gmtoff(time_t t, struct tm *p)
#ifdef HAVE_STRUCT_TM_TM_ZONE
return p->tm_gmtoff;
#else
return timegm(p) - t;
- return timegm(p) - t;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops looks like I added an wild -.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more explanation on the reason of the change, let's discuss that on the bug report.

@AraHaan
Copy link
Contributor Author

AraHaan commented Mar 6, 2017

Now that I think of it I think having TSS instead of TLS on all platforms if possible would be better sollution so that way cygwin would be unofficially supported until we get build bots for cygwin somehow. The trick is figuring out how to make one similar to the windows (MSVC) build bot.

@AraHaan AraHaan closed this Sep 11, 2017
@AraHaan AraHaan deleted the cygwin-3.7-patch branch September 11, 2017 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants