bpo-20891: Py_Initialize() now creates the GIL #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Dec 4, 2017
| @@ -0,0 +1,2 @@ | |||
| Py_Initialize() now creates the GIL. The GIL is not more created "on demand" to | |||
There was a problem hiding this comment.
oops, replaced with "no longer"
|
Is there any documentation to update? |
Done, see my updated PR. |
pitrou
reviewed
Dec 4, 2017
Doc/c-api/init.rst
Outdated
| @@ -818,54 +817,39 @@ code, or when embedding the Python interpreter: | |||
|
|
|||
| This is a no-op when called for a second time. | |||
|
|
|||
| .. versionchanged:: 3.7 | |||
| The :term:`GIL` is now initialized by :c:func:`Py_Initialize()`. | |||
There was a problem hiding this comment.
I would phrase it more explicitly:
This function is now called by :c:func:`Py_Initialize()`, so you don't have to call it yourself anymore.
|
This branch seems to fix the issue for me on macOS 10.12.6 |
|
For benchmark results, see https://bugs.python.org/issue20891#msg308588 |
The GIL is no longer created "on demand" to fix a race condition when PyGILState_Ensure() is called in a non-Python thread.
Remove also mention of the "thread support", since thread support cannot be disabled anymore.
Make the assumption that the GIL is always created (by Py_Initialize()).
|
@vstinner: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIL is not more created "on demand" to fix a race condition when
PyGILState_Ensure() is called in a non-Python thread.
https://bugs.python.org/issue20891