Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32596: Make lazy-load portable #5316

Merged
merged 1 commit into from Jan 26, 2018
Merged

bpo-32596: Make lazy-load portable #5316

merged 1 commit into from Jan 26, 2018

Conversation

methane
Copy link
Member

@methane methane commented Jan 25, 2018 •
edited by bedevere-bot

@methane
bpo-32596: Make lazy-load portable
992c48d 
Global variables should not used as import target.
Use temporary variable instead.
ilevkivskyi
ilevkivskyi approved these changes Jan 25, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@methane methane merged commit 4666ec5 into python:master Jan 26, 2018
@methane methane deleted the concurrent-futures branch January 26, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@methane @ilevkivskyi @the-knights-who-say-ni @bedevere-bot