Cleanup inspect.py #5351
Merged
Cleanup inspect.py #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use isinstance(..) instead of type(..) * use '.. not in ..' instead of 'not .. in .. '
methane
approved these changes
Jan 29, 2018
methane
added a commit
to methane/cpython
that referenced
this pull request
Sep 4, 2019
It should avoid dynamic lookup including `isinstance`. This is regression caused by pythonGH-5351.
methane
added a commit
that referenced
this pull request
Sep 5, 2019
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2019
It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351. (cherry picked from commit 8f9cc87) Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 5, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.