bpo-32839: Add after_info to tkinter #5664

csabella · 2018-02-13T18:27:53Z

https://bugs.python.org/issue32839

Lib/tkinter/__init__.py

Lib/tkinter/test/test_tkinter/test_misc.py

Lib/tkinter/__init__.py

Lib/tkinter/test/test_tkinter/test_misc.py

terryjreedy · 2018-02-13T21:50:41Z

Lib/tkinter/__init__.py

@@ -763,15 +763,31 @@ def after_cancel(self, id):

        Identifier returned by after or after_idle must be
        given as first parameter."""
+        if id is None:
+            return


This makes no sense to me. id is required and AFAKI should not be passed as None. Do after or after_idle ever return None?

Please see my following comment with the Tcl code. I added this because I'm not sure if the original comments about the tuple changing were accurate. I think it was a result of id being None vs it having a value.

Lib/tkinter/__init__.py

bedevere-bot · 2018-02-13T22:36:23Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Lib/tkinter/test/test_tkinter/test_misc.py

csabella · 2018-03-04T15:37:26Z

I pushed a rebase and got the Appveyor error. I'm working on the other concerns about the after_info functionality, so I'll push a fix once those are worked out. Although, this issue on Appveyor does answer the previous question about the after_info() event list containing other events than the ones added in this test. It seems that the other new after* tests are leaving something behind.

Lib/tkinter/__init__.py

Misc/NEWS.d/next/Library/2018-02-13-10-02-54.bpo-32839.McbVz3.rst

Lib/tkinter/__init__.py

terryjreedy · 2019-12-31T18:02:14Z

Cheryl, can you explain the closing? I still think adding after_info would be good.

terryjreedy · 2019-12-31T23:22:15Z

The only reported error, only on Travis, on line 191 is an extra item, 'after#8' (the 'timer' of line 180, I presume), in the tuple returned from .after_info. (The Travis job page somehow disables copying with current Firefox.) On this system, with the tcl/tk used, the preceding root.update() did not remove the 'timer' callback from the list.

I restarted the failing job to see if the failure is repeatable on Travis.

Answer: yes.

ZackerySpytz · 2020-01-04T12:32:31Z

FWIW, I also think adding after_info() would be good.

csabella · 2020-01-26T17:48:12Z

Sorry about closing this prematurely. I had thought there hadn't been much interest in adding the functionality when I originally proposed it, so I was just doing some housekeeping. Good to know there is interest. Having said that, the tests pass locally, so it may be tricky to get them to pass. I have a root.update() to clear the timer event from a previous test, so it seems to work locally but not on Travis. I'll look into it more.

serhiy-storchaka

Please expand the NEWS entry, add a What's New entry apply and test the code suggestion.

The PR looks mostly good to me and I want to land it in 3.9.

Lib/tkinter/__init__.py

Misc/NEWS.d/next/Library/2018-02-13-10-02-54.bpo-32839.McbVz3.rst

github-actions · 2022-08-15T00:12:19Z

This PR is stale because it has been open for 30 days with no activity.

This reverts commit 5b33773.

serhiy-storchaka

I expanded the NEWS entry and added the What's New entry. My last code suggestions turned out to be wrong.

LGTM.

terryjreedy · 2024-04-26T04:40:31Z

I am presuming that my old comments are obsolete.

the-knights-who-say-ni added the CLA signed label Feb 13, 2018

bedevere-bot added the awaiting review label Feb 13, 2018

serhiy-storchaka reviewed Feb 13, 2018

View reviewed changes

terryjreedy requested changes Feb 13, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Feb 13, 2018

terryjreedy reviewed Feb 14, 2018

View reviewed changes

Lib/tkinter/test/test_tkinter/test_misc.py Outdated Show resolved Hide resolved

csabella added 2 commits March 4, 2018 08:40

Add after_info to tkinter

f3598e1

Changes per review.

51bfe2b

csabella force-pushed the bpo32839 branch from 90c6408 to 51bfe2b Compare March 4, 2018 13:43

ZackerySpytz reviewed Dec 27, 2019

View reviewed changes

Lib/tkinter/__init__.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2018-02-13-10-02-54.bpo-32839.McbVz3.rst Outdated Show resolved Hide resolved

Lib/tkinter/__init__.py Outdated Show resolved Hide resolved

csabella closed this Dec 31, 2019

serhiy-storchaka reopened this Dec 31, 2019

Merge branch 'master' into bpo32839

57806b7

Cancel specific timer in test

ff9e774

serhiy-storchaka requested changes Mar 22, 2020

View reviewed changes

Lib/tkinter/__init__.py Show resolved Hide resolved

Misc/NEWS.d/next/Library/2018-02-13-10-02-54.bpo-32839.McbVz3.rst Outdated Show resolved Hide resolved

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 15, 2022

serhiy-storchaka added 5 commits April 25, 2024 13:04

Update Lib/tkinter/__init__.py

5b33773

Merge commit 'c1fb12e5afa09aca3134a9bc0116c31dbcccc5e9~' into bpo32839

0c9d622

Merge commit 'c1fb12e5afa09aca3134a9bc0116c31dbcccc5e9' into bpo32839

26e2249

Merge branch 'main' into bpo32839

8899add

Update NEWS.

94a71a4

serhiy-storchaka added 2 commits April 25, 2024 13:20

Revert "Update Lib/tkinter/__init__.py"

02df0b0

This reverts commit 5b33773.

Silence the linter for What's New.

e83e68d

serhiy-storchaka approved these changes Apr 25, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Apr 25, 2024

terryjreedy approved these changes Apr 26, 2024

View reviewed changes

serhiy-storchaka merged commit 194fd17 into python:main Apr 26, 2024
34 of 35 checks passed

bedevere-app bot removed the awaiting merge label Apr 26, 2024

csabella mentioned this pull request Apr 10, 2022

Add after_info as a function to tkinter #77020

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-32839: Add after_info to tkinter #5664

bpo-32839: Add after_info to tkinter #5664

csabella commented Feb 13, 2018 •

edited by bedevere-bot

Loading

terryjreedy Feb 13, 2018

csabella Feb 14, 2018

bedevere-bot commented Feb 13, 2018

csabella commented Mar 4, 2018

terryjreedy commented Dec 31, 2019

terryjreedy commented Dec 31, 2019 •

edited

Loading

ZackerySpytz commented Jan 4, 2020

csabella commented Jan 26, 2020

serhiy-storchaka left a comment

github-actions bot commented Aug 15, 2022

serhiy-storchaka left a comment

terryjreedy commented Apr 26, 2024

bpo-32839: Add after_info to tkinter #5664

bpo-32839: Add after_info to tkinter #5664

Conversation

csabella commented Feb 13, 2018 • edited by bedevere-bot Loading

terryjreedy Feb 13, 2018

Choose a reason for hiding this comment

csabella Feb 14, 2018

Choose a reason for hiding this comment

bedevere-bot commented Feb 13, 2018

csabella commented Mar 4, 2018

terryjreedy commented Dec 31, 2019

terryjreedy commented Dec 31, 2019 • edited Loading

ZackerySpytz commented Jan 4, 2020

csabella commented Jan 26, 2020

serhiy-storchaka left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 15, 2022

serhiy-storchaka left a comment

Choose a reason for hiding this comment

terryjreedy commented Apr 26, 2024

csabella commented Feb 13, 2018 •

edited by bedevere-bot

Loading

terryjreedy commented Dec 31, 2019 •

edited

Loading