Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing coroutine declaration in the asyncio documentation. #5964

Merged
merged 1 commit into from Mar 3, 2018
Merged

Fix missing coroutine declaration in the asyncio documentation. #5964

merged 1 commit into from Mar 3, 2018

Conversation

achimnol
Copy link
Contributor

@achimnol achimnol commented Mar 3, 2018

It's a simple fix to add a missing "coroutine" function descriptor in the asyncio docs.

@asvetlov
Copy link
Contributor

asvetlov commented Mar 3, 2018

Good catch.
The fix is very tiny, no need for issue and news update I guess.

@asvetlov asvetlov merged commit 13cfd57 into python:master Mar 3, 2018
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @achimnol for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @achimnol for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2018
@achimnol @miss-islington
Fix missing coroutine declaration in the asyncio documentation. (pyth…
43117cd 
…onGH-5964)

(cherry picked from commit 13cfd57)

Co-authored-by: Joongi Kim <me@daybreaker.info>
@bedevere-bot
Copy link

GH-5966 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2018
@achimnol @miss-islington
Fix missing coroutine declaration in the asyncio documentation. (pyth…
1b4fb87 
…onGH-5964)

(cherry picked from commit 13cfd57)

Co-authored-by: Joongi Kim <me@daybreaker.info>
@bedevere-bot
Copy link

GH-5967 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 3, 2018
@miss-islington @achimnol
Fix missing coroutine declaration in the asyncio documentation. (GH-5964
0f7cf7e 
)

(cherry picked from commit 13cfd57)

Co-authored-by: Joongi Kim <me@daybreaker.info>
miss-islington added a commit that referenced this pull request Mar 3, 2018
@miss-islington @achimnol
Fix missing coroutine declaration in the asyncio documentation. (GH-5964
bd92cfe 
)

(cherry picked from commit 13cfd57)

Co-authored-by: Joongi Kim <me@daybreaker.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@achimnol @asvetlov @bedevere-bot @miss-islington @the-knights-who-say-ni