Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-32517: fix test_read_pty_output() hangs on macOS 10.13.2+ (GH-6037) #6038

Merged
merged 1 commit into from Mar 9, 2018
Merged

[3.7] bpo-32517: fix test_read_pty_output() hangs on macOS 10.13.2+ (GH-6037) #6038

merged 1 commit into from Mar 9, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 9, 2018 •
edited by bedevere-bot

test_asyncio hangs indefinitely on macOS 10.13.2+ on read_pty_output()
using the KqueueSelector. Closing proto.transport (as is done in
write_pty_output()) seems to fix it.
(cherry picked from commit 12f74d8)

Co-authored-by: Nathan Henrie n8henrie@users.noreply.github.com

https://bugs.python.org/issue32517

@n8henrie @miss-islington
bpo-32517: fix test_read_pty_output() hangs on macOS 10.13.2+ (python…
a660488 
…GH-6037)

test_asyncio hangs indefinitely on macOS 10.13.2+ on `read_pty_output()`
using the KqueueSelector. Closing `proto.transport` (as is done in
`write_pty_output()`) seems to fix it.
(cherry picked from commit 12f74d8)

Co-authored-by: Nathan Henrie <n8henrie@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 9, 2018
Merged
ned-deily
ned-deily requested changes Mar 9, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1st1 Looks like you previously added a skip of this test on 3.7 / master. That's why it only fails on 3.6!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Contributor Author

@n8henrie and @1st1: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3c39beb into python:3.7 Mar 9, 2018
@miss-islington
Copy link
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-12f74d8-3.7 branch March 9, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily requested changes

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miss-islington @bedevere-bot @1st1 @ned-deily @the-knights-who-say-ni @n8henrie