Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33041: Rework compiling an "async for" loop. #6142

Merged
merged 3 commits into from Mar 23, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 18, 2018

  • Added new opcode END_ASYNC_FOR.
  • Setting global StopAsyncIteration no longer breaks "async for" loops.
  • Jumping into an "async for" loop is now disabled.
  • Jumping out of an "async for" loop no longer corrupts the stack.
  • Simplify the compiler.

https://bugs.python.org/issue33041

* Added new opcode END_ASYNC_FOR.
* Setting global StopAsyncIteration no longer breaks "async for" loops.
* Jumping into an "async for" loop is now disabled.
* Jumping out of an "async for" loop no longer corrupts the stack.
* Simplify the compiler.
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Mar 18, 2018
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Serhiy. Thanks!

@serhiy-storchaka serhiy-storchaka merged commit 702f8f3 into python:master Mar 23, 2018
@bedevere-bot
Copy link

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants