Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33099: Fix test_poplib hangs after error #6428

Closed
wants to merge 5 commits into from
Closed

bpo-33099: Fix test_poplib hangs after error #6428

wants to merge 5 commits into from

Conversation

methane
Copy link
Member

@methane methane commented Apr 9, 2018 •
edited by bedevere-bot

This fixes resource leaks in the test and reveals real errors.

https://bugs.python.org/issue33099

@methane
bpo-33099: Fix test_poplib hangs after error
331844a 
This fixes resource leaks in the test and reveals real errors.
@methane methane requested a review from a team as a code owner April 9, 2018 10:04
tiran
tiran requested changes Apr 9, 2018
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert try / bare except to try/finally and remove the print_exc line. The same fix should be applied to other tests that use asyncore (ftplib, smtplib, smtpd?)

Lib/test/test_poplib.py Outdated
self.client = poplib.POP3(self.server.host, self.server.port, timeout=3)
try:
self.client = poplib.POP3(self.server.host, self.server.port, timeout=3)
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be try/finally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When setUp() succeeded, tearDown() do it.
So this should be except:, not finally:.

Lib/test/test_poplib.py Outdated
self.client = poplib.POP3_SSL(self.server.host, self.server.port)
try:
self.client = poplib.POP3_SSL(self.server.host, self.server.port)
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try/finally

Lib/test/test_poplib.py Outdated
try:
self.client = poplib.POP3(self.server.host, self.server.port, timeout=3)
self.client.stls()
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try/finally

Lib/test/test_poplib.py Outdated
try:
self.client = poplib.POP3(self.server.host, self.server.port, timeout=3)
except:
traceback.print_exc()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add print_exc?

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

serhiy-storchaka
serhiy-storchaka reviewed Apr 9, 2018
View reviewed changes
Lib/test/test_poplib.py Outdated
try:
self.client = poplib.POP3(self.server.host, self.server.port, timeout=3)
except:
self.server.stop()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can self.server.stop() fail? Is it worth to rewrite the code as:

try:
    self.server.stop()
finally:
    self.server = None
    raise

or

server = self.server
self.server = None
server.stop()
raise

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we shouldn't complicate test code for non-real errors.
It's not late to fix it after the possibility become real.

@methane
Copy link
Member Author

methane commented Apr 9, 2018

"I have made the requested changes; please review again."

@tiran I added same cleanup to test_os and test_ftplib.
test_smtplib and test_smtpd has different architecture. They don't use server threads. So they must not hang for dangling threads.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@methane
Copy link
Member Author

methane commented May 28, 2018

Same fix is commited via #6865.

@methane methane closed this May 28, 2018
@methane methane deleted the test_poplib-hang branch July 23, 2018 08:27
@jayyyin jayyyin mannequin mentioned this pull request May 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@tiran tiran tiran requested changes

Assignees
No one assigned
Labels
awaiting change review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@methane @bedevere-bot @tiran @serhiy-storchaka @the-knights-who-say-ni