Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33265: use an actual method instead of a method-like function in ExitStack #6456

Merged
merged 1 commit into from
Apr 13, 2018
Merged

bpo-33265: use an actual method instead of a method-like function in ExitStack #6456

merged 1 commit into from
Apr 13, 2018

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Apr 12, 2018 •
edited
Loading

@jdemeyer jdemeyer requested a review from 1st1 as a code owner April 12, 2018 05:28
@jdemeyer jdemeyer changed the title bpo-33265: use an actual method instead of a method-like function bpo-33265: use an actual method instead of a method-like function in ExitStack Apr 12, 2018
@ncoghlan
Copy link
Contributor

Changes to implementation details still get NEWS entries, since they can help folks track down what changed that unexpectedly broke their code.

Skipping the NEWS entry entirely is for either follow-up PRs to not-yet-released changes that already have a NEWS entry, or for minor docs changes (like typo fixes).

ncoghlan
ncoghlan approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me for the actual change - I think the only reason I didn't do it this way originally is because it didn't occur to me.

@1st1
Copy link
Member

1st1 commented Apr 13, 2018

lgtm!

@jdemeyer
Copy link
Contributor Author

Changes to implementation details still get NEWS entries, since they can help folks track down what changed that unexpectedly broke their code.

OK, news added.

@ncoghlan ncoghlan merged commit 23ab5ee into python:master Apr 13, 2018
@ncoghlan
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdemeyer @ncoghlan @1st1 @the-knights-who-say-ni @bedevere-bot