Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33358 Fix test_pre_initialization_sys_options when building with --enable-shared #6612

Merged
merged 2 commits into from Apr 27, 2018
Merged

bpo-33358 Fix test_pre_initialization_sys_options when building with --enable-shared #6612

merged 2 commits into from Apr 27, 2018
+3 −1

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 26, 2018 •
edited by bedevere-bot

@pablogsal
Copy link
Member Author

CC: @vstinner

vstinner
vstinner requested changes Apr 27, 2018
View reviewed changes
Misc/NEWS.d/next/Core and Builtins/2018-04-26-22-40-08.bpo-33358.VRMsp2.rst Outdated
@@ -0,0 +1,2 @@
Fix `test_pre_initialization_sys_options` when building with --enable-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a better section for your fix: Tests.

If you write a NEWS entry, mention at least the name of the test (file): test_embed. Example:

Fix ``test_embed.test_pre_initialization_sys_options()``

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner
Copy link
Member

I tested manually --enable-shared: test_embed fails without this change, and pass with this change.

@vstinner vstinner merged commit 4114846 into python:master Apr 27, 2018
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6618 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2018
@pablogsal @miss-islington
bpo-33358: Fix test_embed.test_pre_initialization_sys_options (python…
9ba7e04 
…GH-6612)

Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Apr 27, 2018
@miss-islington @pablogsal
bpo-33358: Fix test_embed.test_pre_initialization_sys_options (GH-6612)
dd3ede7 
Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal deleted the bpo33358 branch April 27, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pablogsal @bedevere-bot @vstinner @miss-islington @the-knights-who-say-ni