Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33012: Fix invalid function cast warnings with gcc 8 #6748

Merged
merged 2 commits into from
Nov 27, 2018
Merged

bpo-33012: Fix invalid function cast warnings with gcc 8 #6748

merged 2 commits into from
Nov 27, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 10, 2018 •
edited by bedevere-bot
Loading

for method conventions different from METH_NOARGS, METH_O and
METH_VARARGS in Argument Clinic generated code.

https://bugs.python.org/issue33012

@xdegaye
Copy link
Contributor

xdegaye commented Jun 4, 2018

Shouldn't these changes be made in the generator instead, i.e. in ./Tools/clinic/clinic.py ?

@xdegaye
Copy link
Contributor

xdegaye commented Jun 4, 2018

Followed by the command:

make regen-all

@methane
Copy link
Member

methane commented Jun 4, 2018

@xdegaye I think that's @serhiy-storchaka did. See
https://github.com/python/cpython/pull/6748/files#diff-5e15637e15d50f49f6cb1d7f69fcab4b

@xdegaye
Copy link
Contributor

xdegaye commented Jun 4, 2018

@methane you are right, sorry for the noise.

@serhiy-storchaka serhiy-storchaka requested a review from a team September 23, 2018 18:14
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@vstinner
Copy link
Member

@serhiy-storchaka: Can you please update/rebase your change?

@vstinner vstinner mentioned this pull request Oct 23, 2018
Merged
@vstinner
Copy link
Member

See also PR #6008 and https://bugs.python.org/issue33015

@serhiy-storchaka
bpo-33012: Fix invalid function cast warnings with gcc 8
a686d9d 
for method conventions different from METH_NOARGS, METH_O and
METH_VARARGS in Argument Clinic generated code.
@serhiy-storchaka
Use (void(*)(void)) instead of (void *).
49cd69e
@serhiy-storchaka serhiy-storchaka merged commit 4a934d4 into python:master Nov 27, 2018
@serhiy-storchaka serhiy-storchaka deleted the func-cast-warns-clinic branch November 27, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serhiy-storchaka @xdegaye @methane @the-knights-who-say-ni @vstinner @bedevere-bot