bpo-33487: improve BZ2File Deprecation and documentation. #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrixise
requested changes
May 14, 2018
| @@ -0,0 +1,3 @@ | |||
| BZ2file now emit a DeprecationWarning when buffering=None is passed, the | |||
| deprecation mesage and documentation also now explicitely state it is | |||
There was a problem hiding this comment.
there is a typo in your "message".
There was a problem hiding this comment.
Oops, thanks. Fixed.
Emit warning when None passed explicitly, list Python version since deprecation in warning message and docs.
Carreau
force-pushed
the
bz2file-deprecation
branch
from
df858f2
to
536d35f
Compare
|
Updated version since deprecation as apparently it's deprecated since 3.0. |
gpshead
approved these changes
Sep 11, 2018
|
Thanks @matrixise amd @gpshead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit warning when None passed explicitly, list Python version since
deprecation in warning message and docs.
https://bugs.python.org/issue33487