Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33580: Make binary/text file glossary entries follow most common "see also" style #6991

Merged

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented May 19, 2018

@serhiy-storchaka
Copy link
Member

Unifying the style may be good, but you remove the part of information which accents the difference between binary and text files.

@andresdelfino
Copy link
Contributor Author

I have updated the PR.

@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2018
…"see also" style. (pythonGH-6991)

(cherry picked from commit 0c4be82)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-7012 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2018
…"see also" style. (pythonGH-6991)

(cherry picked from commit 0c4be82)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-7013 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 20, 2018
…"see also" style. (GH-6991)

(cherry picked from commit 0c4be82)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the fix-binary-and-text-objects branch May 20, 2018 16:03
serhiy-storchaka pushed a commit that referenced this pull request May 20, 2018
…"see also" style. (GH-6991) (GH-7012)

(cherry picked from commit 0c4be82)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants