bpo-31368: Enhance os.preadv() documentation #7254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
May 30, 2018
Doc/library/os.rst
Outdated
| resources. | ||
|
|
||
| Currently, on Linux, this feature is usable only on a file descriptor opened | ||
| using the O_DIRECT flag. |
There was a problem hiding this comment.
O_DIRECT should be written :data:O_DIRECT to get a link to its doc.
| leaving the file offset unchanged. *buffers* must be a sequence of | ||
| :term:`bytes-like objects <bytes-like object>`. Buffers are processed in | ||
| array order. Entire contents of the first buffer is written before | ||
| proceeding to the second, and so on. |
There was a problem hiding this comment.
Hum, a sentence like "The flags argument contains a bitwise OR of zero or more of the following flags:" is missing here.
|
@vstinner Done! |
vstinner
reviewed
May 30, 2018
Doc/library/os.rst
Outdated
| resources. | ||
|
|
||
| Currently, on Linux, this feature is usable only on a file descriptor opened | ||
| using the :data:`O_DIRECT`flag. |
There was a problem hiding this comment.
missing space between ` and flag, no?
There was a problem hiding this comment.
Yup, sorry about that! Done
|
Thanks @pablogsal for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @pablogsal. I merged your PR and will backport it to 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2018
(cherry picked from commit 02e2a08) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-7258 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this patch by @vstinner
https://bugs.python.org/issue31368