Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel #7468

Merged
merged 1 commit into from Sep 30, 2019
Merged

bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel #7468

merged 1 commit into from Sep 30, 2019

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jun 7, 2018 •
edited by bedevere-bot

@1st1 1st1 requested a review from asvetlov as a code owner June 7, 2018 05:02
@1st1 1st1 requested a review from njsmith June 7, 2018 05:02
dimaqq
dimaqq reviewed Jun 7, 2018
View reviewed changes
Include/genobject.h Show resolved Hide resolved
Lib/asyncio/base_events.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Core and Builtins/2018-06-07-01-01-20.bpo-30773.C31rVE.rst Outdated Show resolved Hide resolved
@asvetlov
Copy link
Contributor

Could you resolve conflicts please?
I'd like to checkout your branch and play with it locally.

@1st1
Copy link
Member Author

1st1 commented Sep 20, 2019

Could you resolve conflicts please?
I'd like to checkout your branch and play with it locally.

Done!

@asvetlov
Copy link
Contributor

@1st1 the PR looks good after fixing a couple comments

@1st1
Copy link
Member Author

1st1 commented Sep 28, 2019

@1st1 the PR looks good after fixing a couple comments

Thanks, will fix it and commit soon.

@1st1 1st1 added the needs backport to 3.8 only security fixes label Sep 30, 2019
@1st1 1st1 merged commit fc4a044 into python:master Sep 30, 2019
@1st1 1st1 deleted the fix_ag_running branch September 30, 2019 05:59
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2019
@1st1 @miss-islington
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
60d38b1 
…rallel (pythonGH-7468)

(cherry picked from commit fc4a044)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 30, 2019
@bedevere-bot
Copy link

GH-16486 is a backport of this pull request to the 3.8 branch.

1st1 added a commit that referenced this pull request Sep 30, 2019
@miss-islington @1st1
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
2f87a7d 
…rallel (GH-7468) (#16486)

(cherry picked from commit fc4a044)

Co-authored-by: Yury Selivanov <yury@magic.io>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@1st1
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
29f37e7 
…rallel (python#7468)
@dimaqq dimaqq mannequin mentioned this pull request Apr 10, 2022
Closed
@graingert graingert mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov left review comments

@dimaqq dimaqq dimaqq left review comments

@njsmith njsmith Awaiting requested review from njsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@1st1 @asvetlov @miss-islington @bedevere-bot @dimaqq @the-knights-who-say-ni