Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33791: Changed README for Mac users #7471

Merged
merged 4 commits into from Jun 8, 2018
Merged

bpo-33791: Changed README for Mac users #7471

merged 4 commits into from Jun 8, 2018

Conversation

atg7000
Copy link
Contributor

@atg7000 atg7000 commented Jun 7, 2018 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

ned-deily
ned-deily requested changes Jun 7, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I agree that the section should be updated. See the review comments.

README.rst Outdated
@@ -62,6 +62,9 @@ You can pass many options to the configure script; run ``./configure --help``
to find out more. On macOS and Cygwin, the executable is called ``python.exe``;
elsewhere it's just ``python``.

If you are running on Mac with the latest updates installed, make sure to install
openSSL or some other SSL software along with Homebrew.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other options besides Homebrew. And other modules are needed. Since this is somewhat of a moving target, suggest just referring to the macOS section of the Python Developer's Guide for now: https://devguide.python.org/setup/#macos-and-os-x

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@atg7000
Copy link
Contributor Author

atg7000 commented Jun 7, 2018

I fixed the CLA thing

@atg7000
Copy link
Contributor Author

atg7000 commented Jun 7, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily
ned-deily requested changes Jun 7, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change! One small nit and then we need to wait for your CLA to be processed by the PSF staff which usually takes a day or two.

README.rst Outdated
@@ -62,6 +62,11 @@ You can pass many options to the configure script; run ``./configure --help``
to find out more. On macOS and Cygwin, the executable is called ``python.exe``;
elsewhere it's just ``python``.

If you are running on Mac with the latest updates installed, make sure to install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit: on Mac -> on macOS

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@atg7000
Copy link
Contributor Author

atg7000 commented Jun 7, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily
ned-deily requested changes Jun 7, 2018
View reviewed changes
README.rst Outdated
@@ -62,6 +62,11 @@ You can pass many options to the configure script; run ``./configure --help``
to find out more. On macOS and Cygwin, the executable is called ``python.exe``;
elsewhere it's just ``python``.

If you are running on MacOS with the latest updates installed, make sure to install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be pedantic but the correct current styling according to Apple is "macOS", not "MacOS", and that's the way it appears elsewhere in README.rst.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ned-deily ned-deily changed the title Changed README for Mac users bpo-33791: Changed README for Mac users Jun 7, 2018
@atg7000
Copy link
Contributor Author

atg7000 commented Jun 7, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@ned-deily ned-deily merged commit ee994d7 into python:master Jun 8, 2018
@miss-islington
Copy link
Contributor

Thanks @atg7000 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7512 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@atg7000 @miss-islington
bpo-33791: Update README for macOS users (pythonGH-7471)
8132ecf 
(cherry picked from commit ee994d7)

Co-authored-by: atg7000 <38963069+atg7000@users.noreply.github.com>
@bedevere-bot
Copy link

GH-7513 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@atg7000 @miss-islington
bpo-33791: Update README for macOS users (pythonGH-7471)
ed390a3 
(cherry picked from commit ee994d7)

Co-authored-by: atg7000 <38963069+atg7000@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @atg7000
bpo-33791: Update README for macOS users (GH-7471)
43202e0 
(cherry picked from commit ee994d7)

Co-authored-by: atg7000 <38963069+atg7000@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @atg7000
bpo-33791: Update README for macOS users (GH-7471)
94b5fab 
(cherry picked from commit ee994d7)

Co-authored-by: atg7000 <38963069+atg7000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@atg7000 @the-knights-who-say-ni @bedevere-bot @miss-islington @ned-deily @methane