bpo-33354 Fix test_ssl.py without skipping. #7697
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again for your contribution, we look forward to reviewing it! |
Lib/test/test_ssl.py
Outdated
| @@ -989,7 +989,7 @@ def test_load_verify_cadata(self): | |||
|
|
|||
|
|
|||
| def test_load_dh_params(self): | |||
| filename = u'dhpäräm.pem' | |||
| filename = 'dhparam.pem' | |||
There was a problem hiding this comment.
You misunderstood the purpose of the test: the test checks that non-ASCII characters are encoded properly.
There was a problem hiding this comment.
Forgive me, as I haven't read over everything extensively. But it fails every time, resulting in that test being skipped. Wouldn't it be better if lines 1003-1006 in commit 6e8f395 were removed altogether? Or am I missing something bigger?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
I'm still not sure test_non_ascii_path() should exist or not.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
There was a problem hiding this comment.
The test is called "test_load_dh_params(self):" and you remove the call to ctx.load_dh_params(fname)... You don't understand the purpose of test.
When you want to change code, you have to explain why. You didn't explain why you want to modify or remove the test.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
"You don't understand the purpose of test." |
|
Hi @mattpallissard, I'm the author of the test. The non-ASCII file name in the test serves an important purpose. It verifies that the API can deal with non-ASCII characters in file names. @vstinner rejected your PR, because you removed the check. |
|
Thanks for the follow up. |
This Is a small PR addressing an issue that was already closed. Rather than simply skipping the test this change allows the test to complete.
https://bugs.python.org/issue33354