Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33951: IDLE test_configdialog: call page.update() in setUpClass #7892

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Jun 24, 2018

This avoids a consistent failure in at least one case when running only a single test method rather than all tests in the module.

The issue came up when running the following on Windows 10 Pro 64-bit:
python -m test -ugui -m test_highlight_target_text_mouse test_idle

(This test failed for perhaps an unrelated reason on Travis CI for GH-7887. I encountered the issue while investigating that failure.)

https://bugs.python.org/issue33951

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions may or may not all be needed, but I do not believe they can hurt and the detected problem is fixed.
Thank you for thinking of this.

@terryjreedy terryjreedy self-assigned this Jun 24, 2018
@terryjreedy terryjreedy changed the title bpo-33951: test_configdialog: call page.update() in setUpClass() methods bpo-33951: IDLE test_configdialog: call page.update() in setUpClass Jun 24, 2018
@terryjreedy
Copy link
Member

Shorten title while adding 'IDLE'

@terryjreedy terryjreedy merged commit 2af9f5d into python:master Jun 24, 2018
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7896 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@bedevere-bot
Copy link

GH-7897 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jun 24, 2018
…-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jun 24, 2018
…-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants