Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33957: Doc: Use better wording #7912

Merged
merged 1 commit into from Jun 26, 2018
Merged

bpo-33957: Doc: Use better wording #7912

merged 1 commit into from Jun 26, 2018

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jun 25, 2018 •
edited by bedevere-bot

@srinivasreddy srinivasreddy changed the title use correct term in place of generic wording bpo-33957: use correct term in place of generic wording Jun 25, 2018
@srinivasreddy srinivasreddy changed the title bpo-33957: use correct term in place of generic wording bpo-33957: use standard term in place of generic wording Jun 25, 2018
@methane methane changed the title bpo-33957: use standard term in place of generic wording bpo-33957: Doc: Use better wording Jun 26, 2018
@srinivasreddy
Copy link
Contributor Author

@methane I have rebased. Thanks a lot.

@methane
Copy link
Member

methane commented Jun 26, 2018

We don't need rebase. All commit logs are squashed when merged.
Rebase waste CI resource and prohibit reviewers review from last reviewed commit.

@methane methane merged commit 866c168 into python:master Jun 26, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @srinivasreddy and @methane, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 866c168a5f9330d8a3ae109fa8baab2509f35cc7 3.6

@bedevere-bot
Copy link

GH-7928 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2018
@srinivasreddy @miss-islington
bpo-33957: Doc: Use better wording (pythonGH-7912)
2d4f62e 
(cherry picked from commit 866c168)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
@srinivasreddy
Copy link
Contributor Author

@methane i am not aware of that. Thanks a lot .

miss-islington added a commit that referenced this pull request Jun 26, 2018
@miss-islington @srinivasreddy
bpo-33957: Doc: Use better wording (GH-7912)
829b766 
(cherry picked from commit 866c168)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy@users.noreply.github.com>
@srinivasreddy srinivasreddy deleted the correct branch November 1, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@methane methane

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srinivasreddy @methane @miss-islington @bedevere-bot @the-knights-who-say-ni