Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27351: Fix ConfigParser.read() documentation and docstring #8123

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 5, 2018

Switch "list" to "iterable" to match with the implementation.

https://bugs.python.org/issue27351

Switch "list" with "iterable" to match with the implementation.
@ZackerySpytz ZackerySpytz force-pushed the bpo-27351-configparser-read-docs-docstring branch from 2ce0441 to a5d96f8 Compare July 6, 2018 00:42
@methane methane added docs Documentation in the Doc dir skip news labels Jul 6, 2018
@ZackerySpytz
Copy link
Contributor Author

The bot failed to link this PR with bpo-27351 (mentioning the issue number here in a comment will fix that).

Copy link
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)
The changes seem fine to me.

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @briancurtin for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2018
…nGH-8123)

Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-9637 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2018
…nGH-8123)

Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-9638 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @ZackerySpytz and @briancurtin, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e45473e3ca31e5b78dc85cab575f5bb60d5b7f8f 2.7

briancurtin pushed a commit that referenced this pull request Sep 29, 2018
Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
briancurtin pushed a commit that referenced this pull request Sep 29, 2018
Switch "list" with "iterable" to match with the implementation.
(cherry picked from commit e45473e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants