Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34125: Enable profiling of method_descriptor in all cases #8416

Merged
merged 1 commit into from Sep 19, 2018

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Jul 23, 2018

list.append([], None) was profiled but list.append([], None, **{}) was not profiled.
Enable profiling for later case.

https://bugs.python.org/issue34125

@jdemeyer
Copy link
Contributor Author

@serhiy-storchaka @vstinner What do you think of this?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have a wider discussion on function calls: https://bugs.python.org/issue29502

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Aug 1, 2018

I would prefer to have a wider discussion on function calls: https://bugs.python.org/issue29502

Regardless of the wider discussion, I think that this is a bug which should be fixed anyway.

Anyway, if you don't like my PR, that's fine and I will close it. But I see no reason for waiting.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Aug 2, 2018

Which changes should be made?

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Aug 8, 2018

I have made the requested changes; please review again (reason: no changes were actually requested)

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@methane
Copy link
Member

methane commented Sep 19, 2018

@jdemeyer I think it's OK to merge this to move PEP 580 forward.
BTW, is this really need to backport? I'm not sure this little inconsistency is really a bug.

@methane methane changed the title bpo-34125: enable profiling of method_descriptor in all cases bpo-34125: Enable profiling of method_descriptor in all cases Sep 19, 2018
@jdemeyer
Copy link
Contributor Author

Thanks for merging it!

I have no strong opinions on the backport. I just see no reasons to not backport it: it's a tiny bug fix which can easily be backported. And having a few more C calls profiled seems unlikely to break stuff.

@jdemeyer jdemeyer deleted the bpo34125 branch September 20, 2018 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants