New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34125: Enable profiling of method_descriptor in all cases #8416
Conversation
@serhiy-storchaka @vstinner What do you think of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have a wider discussion on function calls: https://bugs.python.org/issue29502
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Regardless of the wider discussion, I think that this is a bug which should be fixed anyway. Anyway, if you don't like my PR, that's fine and I will close it. But I see no reason for waiting. |
Which changes should be made? |
I have made the requested changes; please review again (reason: no changes were actually requested) |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
@jdemeyer I think it's OK to merge this to move PEP 580 forward. |
Thanks for merging it! I have no strong opinions on the backport. I just see no reasons to not backport it: it's a tiny bug fix which can easily be backported. And having a few more C calls profiled seems unlikely to break stuff. |
list.append([], None)
was profiled butlist.append([], None, **{})
was not profiled.Enable profiling for later case.
https://bugs.python.org/issue34125