Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29913: fix documentation for compare_networks() #865

Merged
merged 2 commits into from Mar 30, 2017

Conversation

s-sanjay
Copy link
Contributor

updating the doc as discussed in issue 29913

@mention-bot
Copy link

@s-sanjay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@s-sanjay
Copy link
Contributor Author

@zhangyangyu I opened a new PR to fix the doc.

Copy link
Member

@zhangyangyu zhangyangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to improve the documentation not docstring. You could edit Doc/library/ipaddress.rst. And deprecate means a .. deprecated:: 3.7 command in the doc. You could refer to other files. :-)

@s-sanjay
Copy link
Contributor Author

@zhangyangyu ok 👍 I made the change in doc and dropped the change in documentation.

@zhangyangyu
Copy link
Member

You could add your name to Misc/NEWS. :-) And have you signed the CLA?

@s-sanjay
Copy link
Contributor Author

@zhangyangyu I did sign the CLA day before yesterday.

@zhangyangyu
Copy link
Member

zhangyangyu commented Mar 28, 2017

It'll take some time for the CLA to take effect @s-sanjay .
And sorry I made a mistake. I mean add your name to Misc/ACKS. This is a doc change and we don't need an entry in Misc/NEWS, sorry. :-(

@s-sanjay
Copy link
Contributor Author

@zhangyangyu yes I was wondering why it needs to go into NEWS. I updated the commit.

@brettcannon brettcannon added the docs Documentation in the Doc dir label Mar 28, 2017
@zhangyangyu zhangyangyu changed the title bpo-29913 fix documentation for compare_networks() bpo-29913: fix documentation for compare_networks() Mar 30, 2017
@zhangyangyu zhangyangyu merged commit 16f8523 into python:master Mar 30, 2017
@zhangyangyu
Copy link
Member

Thanks @s-sanjay !

@s-sanjay
Copy link
Contributor Author

@zhangyangyu thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants