New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-29913: fix documentation for compare_networks() #865
bpo-29913: fix documentation for compare_networks() #865
Conversation
@s-sanjay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @serhiy-storchaka and @hynek to be potential reviewers. |
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
@zhangyangyu I opened a new PR to fix the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to improve the documentation not docstring. You could edit Doc/library/ipaddress.rst. And deprecate means a .. deprecated:: 3.7
command in the doc. You could refer to other files. :-)
b10bcf1
to
159a4ae
Compare
@zhangyangyu ok 👍 I made the change in doc and dropped the change in documentation. |
You could add your name to Misc/NEWS. :-) And have you signed the CLA? |
@zhangyangyu I did sign the CLA day before yesterday. |
It'll take some time for the CLA to take effect @s-sanjay . |
6e57ebc
to
507ef0e
Compare
@zhangyangyu yes I was wondering why it needs to go into NEWS. I updated the commit. |
Thanks @s-sanjay ! |
@zhangyangyu thank you ! |
updating the doc as discussed in issue 29913