Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtplib documentation fixes #8708

Merged
merged 3 commits into from Aug 13, 2018
Merged

smtplib documentation fixes #8708

merged 3 commits into from Aug 13, 2018

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 8, 2018

Not sure if this needs a bpo entry -- let me know if it does and I'll go file it.

@Mariatta
Copy link
Member

Mariatta commented Aug 9, 2018

Thanks. News entry or bpo issue won't be necessary here. I think this looks good, but I'll wait a couple days and see if @python/email-team wants to review before I merge.

@Mariatta Mariatta merged commit da12063 into python:master Aug 13, 2018
@miss-islington
Copy link
Contributor

Thanks @scop for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Thanks!

@bedevere-bot
Copy link

GH-8753 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8754 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2018
* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2018
* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
miss-islington added a commit that referenced this pull request Aug 13, 2018
* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
miss-islington added a commit that referenced this pull request Aug 13, 2018
* SMTP.startssl: Fix doc on keyfile and certfile use

* SMTP.startssl: Add missing keyfile and certfile deprecation notice

* SMTP: Doc grammar fixes
(cherry picked from commit da12063)

Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
@scop scop deleted the smtplib-docs branch August 15, 2018 06:18
carljm added a commit to carljm/cpython that referenced this pull request Aug 19, 2018
* master: (107 commits)
  bpo-22057: Clarify eval() documentation (pythonGH-8812)
  bpo-34318: Convert deprecation warnings to errors in assertRaises() etc. (pythonGH-8623)
  bpo-22602: Raise an exception in the UTF-7 decoder for ill-formed sequences starting with "+". (pythonGH-8741)
  bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811)
  bpo-34432: doc Mention complex and decimal.Decimal on str.format not about locales (pythonGH-8808)
  bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH-8797)
  Improve error message when mock.assert_has_calls fails (pythonGH-8205)
  Warn not to set SIGPIPE to SIG_DFL (python#6773)
  bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (pythonGH-8796)
  bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
  bpo-34391: Fix ftplib test for TLS 1.3 (pythonGH-8787)
  bpo-34217: Use lowercase for windows headers (pythonGH-8472)
  bpo-34395: Fix memory leaks caused by incautious usage of PyMem_Resize(). (pythonGH-8756)
  bpo-34405: Updated to OpenSSL 1.1.0i for Windows builds. (pythonGH-8775)
  bpo-34384: Fix os.readlink() on Windows (pythonGH-8740)
  closes bpo-34400: Fix undefined behavior in parsetok(). (pythonGH-4439)
  bpo-34399: 2048 bits RSA keys and DH params (python#8762)
  Make regular expressions in test_tasks.py raw strings. (pythonGH-8759)
  smtplib documentation fixes (pythonGH-8708)
  Fix misindented yaml in logging how to example (pythonGH-8604)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants