bpo-34379: Move note for json.dump to function's docs #8730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to bpo-34379
|
GH-8735 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2018
(cherry picked from commit 9e84084) Co-authored-by: Evan Allrich <eallrich@gmail.com>
|
GH-8736 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2018
(cherry picked from commit 9e84084) Co-authored-by: Evan Allrich <eallrich@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 11, 2018
methane
pushed a commit
that referenced
this pull request
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether the
versionchangedornoteshould go first. There's an example in the docs fordatetimewhereversionchangedis first so I went with the same order.Thank you for reviewing and please feel free to request changes as desired.
https://bugs.python.org/issue34379