Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments #8827

Merged
merged 1 commit into from Aug 31, 2018

Conversation

bgerrity
Copy link
Contributor

@bgerrity bgerrity commented Aug 19, 2018

Added previously missing "--list" argument.
Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.

https://bugs.python.org/issue34062

@bgerrity bgerrity requested a review from a team as a code owner August 19, 2018 22:20
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@zooba
Copy link
Member

zooba commented Aug 21, 2018

@bgerrity I think we should have a NEWS entry for this. The "Details" link next to the failed check has the instructions - the comment can be as simple as "Fix --list and --list-paths arguments to py.exe launcher" and put it in the Windows category.

@bgerrity
Copy link
Contributor Author

@zooba Added the NEWS entry

@zooba
Copy link
Member

zooba commented Aug 23, 2018

It looks like you modified some file modes somewhere in the PR, and I don't know what the implications of that are. @vstinner - any idea (chose you at random, sorry :) )?

@bgerrity
Copy link
Contributor Author

@zooba Sorry about that, I cleaned up the bad commits (still learning the finer points of git)

@zooba
Copy link
Member

zooba commented Aug 28, 2018

It's not clear to me why all the CI restarted today, but for some reason it did. Once it's complete then I'll merge. Thanks!

… between short and long arguments

Added previously missing "--list" argument.
Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.
@bgerrity
Copy link
Contributor Author

bgerrity commented Aug 28, 2018

@zooba I think it's good to go?

@zooba zooba merged commit aada63b into python:master Aug 31, 2018
@miss-islington
Copy link
Contributor

Thanks @bgerrity for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@zooba
Copy link
Member

zooba commented Aug 31, 2018

Yep! Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 31, 2018
… between short and long arguments (pythonGH-8827)

Added previously missing "--list" argument.
Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.
(cherry picked from commit aada63b)

Co-authored-by: Brendan Gerrity <brerrity@gmail.com>
@bedevere-bot
Copy link

GH-9015 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Aug 31, 2018
… between short and long arguments (GH-8827)

Added previously missing "--list" argument.
Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.
(cherry picked from commit aada63b)

Co-authored-by: Brendan Gerrity <brerrity@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants