New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments #8827
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
@bgerrity I think we should have a NEWS entry for this. The "Details" link next to the failed check has the instructions - the comment can be as simple as "Fix --list and --list-paths arguments to py.exe launcher" and put it in the Windows category. |
@zooba Added the NEWS entry |
It looks like you modified some file modes somewhere in the PR, and I don't know what the implications of that are. @vstinner - any idea (chose you at random, sorry :) )? |
@zooba Sorry about that, I cleaned up the bad commits (still learning the finer points of git) |
b830f79
to
66a2514
Compare
It's not clear to me why all the CI restarted today, but for some reason it did. Once it's complete then I'll merge. Thanks! |
… between short and long arguments Added previously missing "--list" argument. Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.
@zooba I think it's good to go? |
Yep! Thanks! |
… between short and long arguments (pythonGH-8827) Added previously missing "--list" argument. Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments. (cherry picked from commit aada63b) Co-authored-by: Brendan Gerrity <brerrity@gmail.com>
GH-9015 is a backport of this pull request to the 3.7 branch. |
Added previously missing "--list" argument.
Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments.
https://bugs.python.org/issue34062