bpo-34606: decode extra data only if zip64 end of central directory record is present #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry record is present
auvipy
reviewed
Sep 10, 2018
Lib/test/test_zipfile.py
Outdated
| rmtree(TESTFN2) | ||
|
|
||
| @requires_zlib | ||
| def test_extra_field(self): |
There was a problem hiding this comment.
just curious, is it possible to use Pathlib here?
There was a problem hiding this comment.
I don't see why not, I've picked os.path.join for uniformity just to follow the pattern used in other tests - if Pathlib is preferable option, I can change my code.
auvipy
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During compression extra data is encoded conditionally when Zip64 extension is enabled but decoding used to to unconditional which lead to attempts to decode data that was not encoded in the first place.
https://bugs.python.org/issue34606