Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92106: Add test that subscription works on arbitrary TypedDicts #92176

Merged
merged 1 commit into from
May 2, 2022
Merged

gh-92106: Add test that subscription works on arbitrary TypedDicts #92176

merged 1 commit into from
May 2, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 2, 2022 •
edited

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels May 2, 2022
@JelleZijlstra JelleZijlstra merged commit 81fb354 into python:main May 2, 2022
This was referenced May 2, 2022
Closed
Closed
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 2, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 81fb3548be5a18bf40a6f4505a02cc7fb72c9c34 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@serhiy-storchaka @miss-islington
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
1589aa2 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@JelleZijlstra
Copy link
Member

Backporting this since it's purely a tests change.

@bedevere-bot
Copy link

GH-92200 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 2, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels May 2, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92201 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@serhiy-storchaka @miss-islington
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
24cf08f 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request May 3, 2022
@miss-islington @serhiy-storchaka
gh-92106: Add test that subscription works on arbitrary TypedDicts (G…
adc06cd 
…H-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request May 3, 2022
@miss-islington @serhiy-storchaka
gh-92106: Add test that subscription works on arbitrary TypedDicts (G…
7e55730 
…H-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @serhiy-storchaka @hello-adam
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
bfcabad 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@serhiy-storchaka @miss-islington @JelleZijlstra @bedevere-bot