Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91049: Introduce set vectorcall field API for PyFunctionObject #92257

Merged
merged 26 commits into from
Sep 15, 2022
Merged

gh-91049: Introduce set vectorcall field API for PyFunctionObject #92257

merged 26 commits into from
Sep 15, 2022

Commits on May 3, 2022

  1. Enable setting vectorcall field on PyFunctionObjects

    Andrew Frost committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9cf96ec View commit details
    Browse the repository at this point in the history

  2. check if vectorcall is nondefault before inlining call

    Andrew Frost committed May 3, 2022
    Configuration menu
    Copy the full SHA
    282e3dc View commit details
    Browse the repository at this point in the history

  3. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] committed May 3, 2022
    Configuration menu
    Copy the full SHA
    edcdcf1 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Change how assertion is done

Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
    @adphrost @itamaro
    adphrost and itamaro committed May 3, 2022
    Configuration menu
    Copy the full SHA
    debf5a9 View commit details
    Browse the repository at this point in the history

  5. addressed comments

    Andrew Frost committed May 3, 2022
    Configuration menu
    Copy the full SHA
    473d18d View commit details
    Browse the repository at this point in the history

  6. added to docs

    Andrew Frost committed May 3, 2022
    Configuration menu
    Copy the full SHA
    76e8c9d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Merge branch 'main' into pyfunctionobject-set-vectorcall-field

    Andrew Frost committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    3337459 View commit details
    Browse the repository at this point in the history

  2. updated doc with fix by itamaro

    Andrew Frost committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1543f44 View commit details
    Browse the repository at this point in the history

  3. formatting

    Andrew Frost committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    08082bd View commit details
    Browse the repository at this point in the history

  4. removed doc from 3.11

    Andrew Frost committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    ed93327 View commit details
    Browse the repository at this point in the history

  5. remove lines from 3.11

    Andrew Frost committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    24ffd30 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Apply review feedback from vstinner and markshannon

    @itamaro
    itamaro authored and Andrew Frost committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    89cb4b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'main' into pythongh-91049-set-vectorcall

    @itamaro
    itamaro committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3387d4a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Merge branch 'main' into pythongh-91049-set-vectorcall

    @itamaro
    itamaro committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b0cc28a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Add deopt on func version in LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN

    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    99e4085 View commit details
    Browse the repository at this point in the history

  2. write func version to cache keys version when specializing LOAD_ATTR_… 

    …GETATTRIBUTE_OVERRIDDEN
    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    24353c8 View commit details
    Browse the repository at this point in the history

  3. remove redundant argcount check in LOAD_ATTR_GETATTRIBUTE_OVERRIDDEN … 

    …(replace with assert) - func version check is sufficient
    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    60f7769 View commit details
    Browse the repository at this point in the history

  4. Add missing periods in docs

    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    376ee75 View commit details
    Browse the repository at this point in the history

  5. move warning comment to the function C API docs

    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    56ffc70 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into pyfunctionobject-set-vectorcall-field

    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5340e87 View commit details
    Browse the repository at this point in the history

  7. fix race with pythonGH-96519 (removed func_version in LOAD_ATTR_GETAT… 

    …TRIBUTE_OVERRIDDEN specialization)
    @itamaro
    itamaro committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a5e9d13 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. PEP-7 formatting

    @itamaro
    itamaro committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    12faf52 View commit details
    Browse the repository at this point in the history

  2. Address review feedback 

    - PEP-7 braces
- add assert
- raise TypeError
    @itamaro
    itamaro committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6623470 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Add test for LOAD_ATTR specialization when overriding vectorcall of _… 

    …_getattribute__
    @itamaro
    itamaro committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9149f14 View commit details
    Browse the repository at this point in the history

  2. Improve setvectorcall + specialization testing 

    1. test specialization doesn't trigger when vectorcall is already overridden
2. test specialization gets deopted when vectorcall is overridden after specialization triggered
    @itamaro
    itamaro committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e732d7e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Merge branch 'main' into pyfunctionobject-set-vectorcall-field

    @itamaro
    itamaro committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    84874fb View commit details
    Browse the repository at this point in the history