Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34658: Fix rare subprocess prexec_fn fork error. #9255

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Sep 13, 2018

bpo-34658: Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.

https://bugs.python.org/issue34658

bpo-34658: Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.
@miss-islington
Copy link
Contributor

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a20b6ad into python:master Sep 13, 2018
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2018
[bpo-34658](https://www.bugs.python.org/issue34658): Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.

https://bugs.python.org/issue34658
(cherry picked from commit a20b6ad)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-9256 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a20b6adb5a5880fd22c099961eb9f9787739cefe 3.6

miss-islington added a commit that referenced this pull request Sep 13, 2018
[bpo-34658](https://www.bugs.python.org/issue34658): Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.

https://bugs.python.org/issue34658
(cherry picked from commit a20b6ad)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@gpshead gpshead deleted the subprocess_after_fork_errno branch September 13, 2018 18:10
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 14, 2018
[bpo-34658](https://www.bugs.python.org/issue34658): Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.

https://bugs.python.org/issue34658
(cherry picked from commit a20b6ad)
manual edits to fix it up for 3.6 by gpshead.
gpshead added a commit to gpshead/cpython that referenced this pull request Sep 14, 2018
…9255)

[bpo-34658](https://www.bugs.python.org/issue34658): Fix a rare interpreter unhandled exception state SystemError only
seen when using subprocess with a preexec_fn while an after_parent handler has
been registered with os.register_at_fork and the fork system call fails.

https://bugs.python.org/issue34658.
(cherry picked from commit a20b6ad)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-9292 is a backport of this pull request to the 3.6 branch.

@gpshead
Copy link
Member Author

gpshead commented Sep 14, 2018

3.6 backport turned out to be unneeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants