Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93117: Remove too large sqlite3 bigmemtest #93154

Merged
merged 2 commits into from
May 25, 2022
Merged

gh-93117: Remove too large sqlite3 bigmemtest #93154

merged 2 commits into from
May 25, 2022

Conversation

erlend-aasland
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 23, 2022
@erlend-aasland erlend-aasland linked an issue May 23, 2022 that may be closed by this pull request
test_sqlite3.test_dbapi: test_deserialize_too_much_data_64bit uses undefined size (and requires 24 Exabytes of RAM) #93117
Closed
@erlend-aasland
Copy link
Contributor Author

@serhiy-storchaka, is it worth it to keep this test? It requires an awefully huge buffer.

@erlend-aasland erlend-aasland changed the title gh-93117: Use correct size for sqlite3 deserialize bigmem test gh-93117: Use correct memuse for sqlite3 deserialize bigmem test May 23, 2022
@serhiy-storchaka
Copy link
Member

This test is always skipped. There is no machine with 2**63 bytes of memory (modern architectures have limit of 52 bits for address), and unlikely will be in the nearest century.

@erlend-aasland erlend-aasland changed the title gh-93117: Use correct memuse for sqlite3 deserialize bigmem test gh-93117: Remove too large sqlite3 bigmemtests May 25, 2022
@erlend-aasland erlend-aasland changed the title gh-93117: Remove too large sqlite3 bigmemtests gh-93117: Remove too large sqlite3 bigmemtest May 25, 2022
@erlend-aasland
Copy link
Contributor Author

Thanks Serhiy; I'll remove it.

@erlend-aasland erlend-aasland mentioned this pull request May 25, 2022
Closed
@erlend-aasland erlend-aasland merged commit db3ef0c into python:main May 25, 2022
@erlend-aasland erlend-aasland deleted the sqlite-fix-bigmemtests branch May 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
3 participants
@erlend-aasland @serhiy-storchaka @bedevere-bot