bpo-34685: Skip posix_spawn scheduler tests on BSD #9316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
changed the title
|
Check issue for the rationale |
vstinner
requested changes
Sep 14, 2018
Lib/test/test_posix.py
Outdated
| @@ -1660,14 +1660,17 @@ def test_setsigdef_wrong_type(self): | |||
|
|
|||
| @requires_sched | |||
| def test_setscheduler_only_param(self): | |||
| if sys.platform.startswith(('freebsd', 'netbsd', 'openbsd', 'gnukfreebsd')): | |||
| raise unittest.SkipTest("test may fail on BSD") | |||
There was a problem hiding this comment.
We already skip a similar test on FreeBSD and NetBSD:
# POSIX states that calling sched_setparam() or sched_setscheduler() on
# a process with a scheduling policy other than SCHED_FIFO or SCHED_RR
# is implementation-defined: NetBSD and FreeBSD can return EINVAL.
if not sys.platform.startswith(('freebsd', 'netbsd')):
See commit b402a5c.
Please use the decorator, skipIf or skipUnless:
@unittest.skipUnless(sys.platform == 'win32',
'test specific to the Windows console')
Please also mention the bpo number in the skip message: "bpo-34685: " prefix.
|
When you're done making the requested changes, leave the comment: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34685