[3.11] gh-89828: Do not relay the __class__ attribute in GenericAlias (GH-93754) #93980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-93754) list[int].__class__ returned type, and isinstance(list[int], type) returned True. It caused numerous problems in code that checks isinstance(x, type). (cherry picked from commit f9433ff) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra,
ericvsmith and
rhettinger
as code owners
|
Status check is done, and it's a success ✅ . |
|
Status check is done, and it's a success ✅ . |
bedevere-bot
added
type-bug
|
Status check is done, and it's a success ✅ . |
Fidget-Spinner
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list[int].class returned type, and isinstance(list[int], type)
returned True. It caused numerous problems in code that checks
isinstance(x, type).
(cherry picked from commit f9433ff)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com