Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-84522: Add for-loop to apply-method-to-sequence FAQ #94660

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

kj7rrv
Copy link
Contributor

@kj7rrv kj7rrv commented Jul 7, 2022

Closes gh-84522

Issue gh-84522

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 7, 2022
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev
Copy link
Member

@bedevere-bot No, small doc changes don't.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@rhettinger
Copy link
Contributor

It would be better to leave this as talking about methods only. Just add the for-loop example.

Changing the title of the entry risks breaking external links to the FAQ (for example, from code comments, blog posts, and answers on StackOverflow).

@kj7rrv
Copy link
Contributor Author

kj7rrv commented Jul 7, 2022

@rhettinger is there a way to change the title without changing the link?

Add clearer words and appropriate markup.
@rhettinger rhettinger added the needs backport to 3.11 only security fixes label Nov 11, 2022
@rhettinger rhettinger merged commit 97c493d into python:main Nov 11, 2022
@miss-islington
Copy link
Contributor

Thanks @kj7rrv for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2022
…H-94660)

(cherry picked from commit 97c493d)

Co-authored-by: Samuel Sloniker <sam@kj7rrv.com>
@bedevere-bot
Copy link

GH-99362 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 11, 2022
miss-islington added a commit that referenced this pull request Nov 11, 2022
(cherry picked from commit 97c493d)

Co-authored-by: Samuel Sloniker <sam@kj7rrv.com>
ethanfurman pushed a commit to ethanfurman/cpython that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
6 participants