Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90817: Fix docs: use 'deprecated-removed' when removal version known #94960

Merged
merged 1 commit into from
Aug 3, 2022
Merged

gh-90817: Fix docs: use 'deprecated-removed' when removal version known #94960

merged 1 commit into from
Aug 3, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 18, 2022 •
edited

.. deprecated:: 3.11 3.13 should be .. deprecated-removed:: 3.11 3.13

So instead of:

Deprecated since version 3.11: 3.13

We get:

Deprecated since version 3.11, will be removed in version 3.13.

https://docs.python.org/3.12/library/locale.html#locale.getdefaultlocale

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 18, 2022
@hugovk hugovk requested a review from vstinner July 18, 2022 13:53
@hugovk hugovk added the needs backport to 3.11 only security fixes label Jul 18, 2022
@vstinner vstinner merged commit dc2757a into python:main Aug 3, 2022
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2022
@hugovk @miss-islington
pythongh-90817: Use .. deprecated-removed:: when removal version known (
4176416 
pythonGH-94960)

(cherry picked from commit dc2757a)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 3, 2022
@bedevere-bot
Copy link

GH-95627 is a backport of this pull request to the 3.11 branch.

@hugovk hugovk deleted the 90817-fix-deprecation-removed branch August 3, 2022 21:51
miss-islington added a commit that referenced this pull request Aug 3, 2022
@miss-islington @hugovk
gh-90817: Use .. deprecated-removed:: when removal version known (GH-…
450ee4f 
…94960)

(cherry picked from commit dc2757a)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hugovk @miss-islington @bedevere-bot @vstinner