Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94996: Disallow parsing pos only param with feature_version < (3, 8) #94997

Merged
merged 3 commits into from
Aug 12, 2022
Merged

gh-94996: Disallow parsing pos only param with feature_version < (3, 8) #94997

merged 3 commits into from
Aug 12, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Jul 19, 2022 •
edited by bedevere-bot

@hauntsaninja hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed awaiting review labels Jul 19, 2022
lysnikolaou
lysnikolaou approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou lysnikolaou merged commit b5e3ea2 into python:main Aug 12, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hauntsaninja and @lysnikolaou, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b5e3ea286289fcad12be78480daf3756e350f69f 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2022
@hauntsaninja @miss-islington
pythongh-94996: Disallow parsing pos only params with feature_version…
78c1f2f 
… < (3, 8) (pythonGH-94997)

(cherry picked from commit b5e3ea2)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 12, 2022
@bedevere-bot
Copy link

GH-95931 is a backport of this pull request to the 3.11 branch.

@lysnikolaou
Copy link
Contributor

@hauntsaninja Are you backporting this to 3.10 or should I?

miss-islington added a commit that referenced this pull request Aug 12, 2022
@miss-islington @hauntsaninja
gh-94996: Disallow parsing pos only params with feature_version < (3,…
4abf846 
… 8) (GH-94997)

(cherry picked from commit b5e3ea2)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@lysnikolaou lysnikolaou mentioned this pull request Aug 12, 2022
Closed
@hauntsaninja hauntsaninja deleted the gh-94996 branch August 12, 2022 18:05
@hauntsaninja
Copy link
Contributor Author

I can backport it!

hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Aug 12, 2022
@hauntsaninja
pythongh-94996: Disallow parsing pos only params with feature_version…
daa5fd9 
… < (3, 8) (pythonGH-94997)

(cherry picked from commit b5e3ea2)
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Aug 12, 2022
@hauntsaninja
[3.10] pythongh-94996: Disallow parsing pos only params with feature_…
115bf46 
…version < (3, 8) (pythonGH-94997).

(cherry picked from commit b5e3ea2)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@michael-k michael-k mentioned this pull request Sep 8, 2022
Closed
@AlexWaygood AlexWaygood mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

@lysnikolaou lysnikolaou

Labels
needs backport to 3.10 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hauntsaninja @miss-islington @bedevere-bot @lysnikolaou