Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95011: Migrate syslog module to Argument Clinic #95012

Merged
merged 22 commits into from
Oct 8, 2022
Merged

gh-95011: Migrate syslog module to Argument Clinic #95012

merged 22 commits into from
Oct 8, 2022

Conversation

noamcohen97
Copy link
Contributor

@noamcohen97 noamcohen97 commented Jul 19, 2022 •
edited by bedevere-bot

This improves code readability and performance by delegating all of the argument parsing logic to Clinic.

Fixes #95011

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@noamcohen97 noamcohen97 changed the title Migrate syslog module to Argument Clinic gh-95011: Migrate syslog module to Argument Clinic Jul 19, 2022
@noamcohen97 noamcohen97 mentioned this pull request Jul 19, 2022
Closed
@erlend-aasland
Copy link
Contributor

On hold until #95007 is resolved.

@erlend-aasland
Copy link
Contributor

Also, please don't force push; it does not play well with the GitHub UI. Please use git merge --no-ff main instead.

@arhadthedev
Copy link
Member

Namely, it forces us to reread the whole PR from scratch instead of swiftly looking at a diff:

image

serhiy-storchaka
serhiy-storchaka reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code I found several issues in syslog (#95041). Please wait until I fix them.

Modules/syslogmodule.c Outdated Show resolved Hide resolved
Modules/syslogmodule.c Outdated Show resolved Hide resolved
Modules/syslogmodule.c Outdated Show resolved Hide resolved
erlend-aasland
erlend-aasland requested changes Jul 25, 2022
View reviewed changes
Modules/syslogmodule.c Outdated Show resolved Hide resolved
Modules/syslogmodule.c Outdated Show resolved Hide resolved
Modules/syslogmodule.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

noamcohen97 and others added 4 commits July 26, 2022 07:49
@noamcohen97 @erlend-aasland
Update Modules/syslogmodule.c
a2844f0 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@noamcohen97 @erlend-aasland
Update Modules/syslogmodule.c
9b853db 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@noamcohen97
syslog: better test coverage
30db659
@noamcohen97
syslog: fix ref leak
dde4e7c
@noamcohen97
Copy link
Contributor Author

I have made the requested changes; please review again.
Still waiting for #95058 to be merged.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 30, 2022
Closed
@erlend-aasland
Copy link
Contributor

It looks like Serhiy's comments were addressed. I'm going to land this later today.

@serhiy-storchaka
Copy link
Member

Wait a bit more. I think that the new tests are worth to be backported, so I added them to my branch which adds other tests. I worked on this on Saturday, but I need a few more days to let it mature.

@erlend-aasland
Copy link
Contributor

Ok, thanks for the heads-up. I'll mark this as don't-merge in the meantime.

@erlend-aasland
Copy link
Contributor

Wait a bit more. I think that the new tests are worth to be backported, so I added them to my branch which adds other tests. I worked on this on Saturday, but I need a few more days to let it mature.

@serhiy-storchaka: do you have an issue/PR number for this, so we can track progress?

@erlend-aasland
Copy link
Contributor

Also, please don't force push; it does not play well with the GitHub UI. Please use git merge --no-ff main instead.

☝🏻

@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 6, 2022
Merged
@serhiy-storchaka
Copy link
Member

Sorry for the delay. See #97953. After merging it I'll merge this PR.

@noamcohen97
Copy link
Contributor Author

#98056 fixed the failing tests

serhiy-storchaka
serhiy-storchaka reviewed Oct 8, 2022
View reviewed changes
Lib/test/audit-tests.py Outdated Show resolved Hide resolved
Lib/test/test_audit.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit 5405537 into python:main Oct 8, 2022
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @noamcohen97.

carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into typewatch
71d48c1 
* main:
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
@carljm
Merge branch 'main' into urllibnonet
132c32e 
* main: (5519 commits)
  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)
  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)
  pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)
  Auto-cancel old builds when new commit pushed to branch (python#98009)
  pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
  pythongh-68686: Retire eptag ptag scripts (python#98064)
  pythongh-97922: Run the GC only on eval breaker (python#97920)
  GitHub Workflows security hardening (python#96492)
  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)
  pythongh-97913 Docs: Add walrus operator to the index (python#97921)
  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)
  pythongh-97822: Fix http.server documentation reference to test() function (python#98027)
  pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)
  pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)
  pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@noamcohen97 @mpage
pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012
1e204b1 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate syslog module to Argument Clinic
5 participants
@noamcohen97 @bedevere-bot @erlend-aasland @arhadthedev @serhiy-storchaka