bpo-34334: Don't log traceback twice in QueueHandler #9537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GH-9581 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit d345bb4) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
|
@vsajip Thanks! I think that was the quickest merge I've ever gotten. :-) |
ned-deily
pushed a commit
that referenced
this pull request
Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In QueueHandler in logging, the traceback (exc_info and exc_text) was being appended to the message twice after bpo-31084. This clears
LogRecord.exc_textin the QueueHandler to keep it in sync withexc_info.https://bugs.python.org/issue34334