Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95445: Ensure Windows msi uninstalls document folder successfully #95465

Merged
merged 3 commits into from Aug 1, 2022
Merged

gh-95445: Ensure Windows msi uninstalls document folder successfully #95465

merged 3 commits into from Aug 1, 2022

Conversation

neonene
Copy link
Contributor

@neonene neonene commented Jul 30, 2022 •
edited by bedevere-bot

@neonene neonene requested a review from a team as a code owner July 30, 2022 14:10
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.11 only security fixes labels Jul 31, 2022
@neonene
Copy link
Contributor Author

neonene commented Jul 31, 2022 •
edited

Before HTML docs are introduced, Doc folder was deleted using Tools/msi/csv_to_wxs.py, which now deletes html folder, not Doc (parent).

<CreateFolder /> in this patch may be unnecessary, which will create Doc folder even without documents if Include_doc option is on.

@zooba
Copy link
Member

zooba commented Aug 1, 2022

Awesome, thanks!

@zooba zooba merged commit 7d89738 into python:main Aug 1, 2022
@miss-islington
Copy link
Contributor

Thanks @neonene for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @neonene and @zooba, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7d8973870bb079bf71d094cd966d6b6336f1e25f 3.11

@zooba zooba added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 1, 2022
@miss-islington
Copy link
Contributor

Thanks @neonene for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 1, 2022
@bedevere-bot
Copy link

GH-95536 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2022
@neonene @miss-islington
pythongh-95445: Ensure Windows msi uninstalls document folder success…
5e1b458 
…fully (pythonGH-95465)

(cherry picked from commit 7d89738)

Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 1, 2022
@miss-islington @neonene
gh-95445: Ensure Windows msi uninstalls document folder successfully (G…
3192fd7 
…H-95465)

(cherry picked from commit 7d89738)

Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@neonene neonene deleted the msidoc branch August 1, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees

@zooba zooba

Labels
OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neonene @zooba @miss-islington @bedevere-bot @kumaraditya303