gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound #95570

graingert · 2022-08-02T11:46:00Z

Issue: make asyncio.Timeout and asyncio.TaskGroup fail early when used incorrectly #95569

graingert · 2022-08-02T11:46:59Z

Lib/asyncio/taskgroups.py

-            errors = self._errors
-            self._errors = None
-
-            me = BaseExceptionGroup('unhandled errors in a TaskGroup', errors)
-            raise me from None


errors and me leave a cycle here, we need to unset them in a finally

Lib/asyncio/timeouts.py

graingert · 2022-08-02T12:05:29Z

Lib/asyncio/taskgroups.py

+                # Exceptions are heavy objects that can have object
+                # cycles (bad for GC); let's not keep a reference to
+                # a bunch of them.
+                self._errors = None


could do this so that info.append(f'errors={len(self._errors)}') works ?

Suggested change

self._errors = None

self._errors = range(len(self._errors))

graingert · 2022-08-02T12:08:52Z

Lib/asyncio/taskgroups.py

@@ -185,7 +186,7 @@ def _on_task_done(self, task):
        if self._parent_task.done():
            # Not sure if this case is possible, but we want to handle


I think this is not possible because self._errors.append(exc) on line 182 will fail first with AttributeError: 'NoneType' object has no attribute 'append'

pythongh-95569 make asyncio.Timeout and asyncio.TaskGroup loop-bound

94f4c6b

bedevere-bot added the awaiting review label Aug 2, 2022

graingert commented Aug 2, 2022

View reviewed changes

Lib/asyncio/timeouts.py Outdated Show resolved Hide resolved

Update Lib/asyncio/timeouts.py

a36245c

graingert commented Aug 2, 2022

View reviewed changes

gvanrossum changed the title ~~gh-95569: make asyncio.Timeout and asyncio.TaskGroup loop-bound~~ gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound Oct 25, 2022

kumaraditya303 closed this May 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound #95570

gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound #95570

graingert commented Aug 2, 2022 •

edited by bedevere-bot

graingert Aug 2, 2022

graingert Aug 2, 2022

graingert Aug 2, 2022

		@@ -185,7 +186,7 @@ def _on_task_done(self, task):
		if self._parent_task.done():
		# Not sure if this case is possible, but we want to handle

gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound #95570

gh-95569: Make asyncio.timeout and asyncio.TaskGroup loop-bound #95570

Conversation

graingert commented Aug 2, 2022 • edited by bedevere-bot

graingert Aug 2, 2022

Choose a reason for hiding this comment

graingert Aug 2, 2022

Choose a reason for hiding this comment

graingert Aug 2, 2022

Choose a reason for hiding this comment

graingert commented Aug 2, 2022 •

edited by bedevere-bot